[WIP] Sync features with Node 9#24
Conversation
|
The new |
|
Think I'll split this up so we can get promisify out the door first :P not that many people really need the new format features, probably! |
|
How could I help get at least the |
|
What's the status here? |
|
Ping @goto-bus-stop |
|
promisify/callbackify was landed separately, debuglog is in another PR. Maybe we can extract the I can't commit enough time to finish |
| return debugs[set]; | ||
| }; | ||
|
|
||
| var customInspectSymbol = typeof Symbol !== 'undefined' ? Symbol('util.inspect.custom') : undefined; |
There was a problem hiding this comment.
Node 10.12 and newer registers the util.inspect.custom symbol as nodejs.util.inspect.custom, making it possible to use Symbol.for('nodejs.util.inspect.custom') to get the equivalent util.inspect.custom symbol without depending on util:
| var customInspectSymbol = typeof Symbol !== 'undefined' ? Symbol('util.inspect.custom') : undefined; | |
| var customInspectSymbol = typeof Symbol !== 'undefined' && typeof Symbol.for !== 'undefined' ? Symbol.for('nodejs.util.inspect.custom') : undefined; |
There was a problem hiding this comment.
Browsers, however, don’t register it, so I’d you don’t have util.inspect, there’s no point in having the symbol - why not just depend on util?
There was a problem hiding this comment.
Also, node 6.6-10.11 all require this code, and can’t rely on the shared symbol.
5 participants
Still need to port: